Skip to content

Conversation

ejona86
Copy link
Member

@ejona86 ejona86 commented Apr 18, 2023

The point of the sorting is to reduce the chances of merge conflicts. I greatly prefer verboseness over cleverness in examples, but the tasks can only be sorted manually and there's so many of them.

It is counter-productive to do this for the examples that have their own project folder, as there's so few tasks in that case that they don't need to be ordered.


I don't mind if you don't like this approach. In #10059 I realized this still needed some love. Sorting the existing applicationDistribution was easy, but the tasks would have been a PITA.

The point of the sorting is to reduce the chances of merge conflicts. I
greatly prefer verboseness over cleverness in examples, but the tasks
can only be sorted manually and there's so many of them.

It is counter-productive to do this for the examples that have their own
project folder, as there's so few tasks in that case that they don't
need to be ordered.
@ejona86 ejona86 requested a review from temawi April 18, 2023 16:13
Copy link
Contributor

@temawi temawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this approach seems fine to me.

@ejona86 ejona86 merged commit 2e5cc84 into grpc:master Apr 18, 2023
@ejona86 ejona86 deleted the examples-scripts-sorted branch April 18, 2023 16:54
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants