Skip to content

test for Decompressed gRPC message exceeds maximum size #12428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

test for Decompressed gRPC message exceeds maximum size #12428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
483423a
end-to-end test for decompressedMessageTooLong
panchenko Oct 17, 2025
b2e5acf
checkstyle
panchenko Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion interop-testing/src/main/java/io/grpc/testing/integration/AbstractInteropTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2030,7 +2030,7 @@ private void assertPayload(Payload expected, Payload actual) {
}
}

private static void assertCodeEquals(Status.Code expected, Status actual) {
protected static void assertCodeEquals(Status.Code expected, Status actual) {
assertWithMessage("Unexpected status: %s", actual).that(actual.getCode()).isEqualTo(expected);
}

Expand Down
31 changes: 30 additions & 1 deletion interop-testing/src/test/java/io/grpc/testing/integration/TransportCompressionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
package io.grpc.testing.integration;

import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertThrows;
import static org.junit.Assert.assertTrue;

import com.google.protobuf.ByteString;
Expand All @@ -37,6 +38,8 @@
import io.grpc.ServerCall.Listener;
import io.grpc.ServerCallHandler;
import io.grpc.ServerInterceptor;
import io.grpc.Status.Code;
import io.grpc.StatusRuntimeException;
import io.grpc.internal.GrpcUtil;
import io.grpc.netty.InternalNettyChannelBuilder;
import io.grpc.netty.InternalNettyServerBuilder;
Expand All @@ -53,7 +56,10 @@
import java.io.OutputStream;
import org.junit.Before;
import org.junit.BeforeClass;
import org.junit.Ignore;
import org.junit.Rule;
import org.junit.Test;
import org.junit.rules.TestName;
import org.junit.runner.RunWith;
import org.junit.runners.JUnit4;

Expand Down Expand Up @@ -84,10 +90,16 @@ public static void registerCompressors() {
compressors.register(Codec.Identity.NONE);
}

@Rule
public final TestName currentTest = new TestName();

@Override
protected ServerBuilder<?> getServerBuilder() {
NettyServerBuilder builder = NettyServerBuilder.forPort(0, InsecureServerCredentials.create())
.maxInboundMessageSize(AbstractInteropTest.MAX_MESSAGE_SIZE)
.maxInboundMessageSize(
DECOMPRESSED_MESSAGE_TOO_LONG_METHOD_NAME.equals(currentTest.getMethodName())
? 1000
: AbstractInteropTest.MAX_MESSAGE_SIZE)
.compressorRegistry(compressors)
.decompressorRegistry(decompressors)
.intercept(new ServerInterceptor() {
Expand Down Expand Up @@ -126,6 +138,23 @@ public void compresses() {
assertTrue(FZIPPER.anyWritten);
}

private static final String DECOMPRESSED_MESSAGE_TOO_LONG_METHOD_NAME =
"decompressedMessageTooLong";

@Test
@Ignore("for PR #12360")
public void decompressedMessageTooLong() {
assertEquals(DECOMPRESSED_MESSAGE_TOO_LONG_METHOD_NAME, currentTest.getMethodName());
final SimpleRequest bigRequest = SimpleRequest.newBuilder()
.setPayload(Payload.newBuilder().setBody(ByteString.copyFrom(new byte[10_000])))
.build();
StatusRuntimeException e = assertThrows(StatusRuntimeException.class,
() -> blockingStub.withCompression("gzip").unaryCall(bigRequest));
assertCodeEquals(Code.RESOURCE_EXHAUSTED, e.getStatus());
assertEquals("Decompressed gRPC message exceeds maximum size 1000",
e.getStatus().getDescription());
}

@Override
protected NettyChannelBuilder createChannelBuilder() {
NettyChannelBuilder builder = NettyChannelBuilder.forAddress(getListenAddress())
Expand Down