core: add inboundHeaders() to ClientStreamTracer. #2921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejona86
approved these changes
Apr 17, 2017
| /** | ||
| * Headers has been sent to the socket. | ||
| */ | ||
| public void headersSent() { |
Member
There was a problem hiding this comment.
Should headersSent be outboundHeaders? I was going to suggest changing inboundHeaders until I realized it matched the methods in StreamTracer better. That can be done in a later PR.
Contributor
Author
There was a problem hiding this comment.
Renamed in the PR, because since the tracer API has not been released, it would be easier for me to back-port the rename to the 1.3.x branch right now than doing it after the release.
zhangkun83
added
the
TODO:backport
zhangkun83
added a commit
to zhangkun83/grpc-java
that referenced
this pull request
Apr 17, 2017
This is a partial backport of grpc#2921 into v1.3.x The addition of inboundHeaders is not backported as it turns out to be non-trivial as OkHttp is still on AbstractClientStream on v1.3.x while has switched to AbstractClientStream2 on master.
zhangkun83
added a commit
that referenced
this pull request
Apr 18, 2017
This is a partial backport of #2921 into v1.3.x The addition of inboundHeaders is not backported as it turns out to be non-trivial as OkHttp is still on AbstractClientStream on v1.3.x while has switched to AbstractClientStream2 on master.
Member
|
Backport was done in #2922 |
ejona86
removed
the
TODO:backport
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.