util: improve scalabiltiy of RR load balancer #3579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangkun83
reviewed
Oct 13, 2017
Contributor
zhangkun83
left a comment
zhangkun83
left a comment
There was a problem hiding this comment.
Mostly LGTM, except for a small comment.
| @VisibleForTesting | ||
| static final Attributes.Key<Ref<ConnectivityStateInfo>> STATE_INFO = | ||
| Attributes.Key.of("state-info"); | ||
| private static final Attributes.Key<Ref<EquivalentAddressGroup>> ADDRESS_GROUP = |
Contributor
There was a problem hiding this comment.
You don't need this, because Subchannel.getAddresses() is exactly what you need.
zhangkun83
approved these changes
Oct 16, 2017
In relative order of importance: * Don't acquire lock when picking subchannel. * Use O(1) lookup for updating channel state * Use non synchronized ref instead of AtomicReference * Dont store size in picker. * make class final * remove test that was not valid
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In relative order of importance: