Skip to content

Conversation

@zhangkun83
Copy link
Contributor

This is required by an internal use case. We have already been doing
so for Subchannels.

This is required by an internal use case.  We have already been doing
so for Subchannels.
Copy link
Contributor

@carl-mastrangelo carl-mastrangelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


// Must be called from channelExecutor
private void handleInternalSubchannelState(ConnectivityStateInfo newState) {
if ((newState.getState() == TRANSIENT_FAILURE || newState.getState() == IDLE)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove double parens

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@zhangkun83 zhangkun83 merged commit 04f4065 into grpc:master Oct 18, 2017
@zhangkun83 zhangkun83 deleted the grpclb_refresh_dns branch October 18, 2017 22:31
@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants