Skip to content

netty: fix server keepalive unexpected ping ack #3730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2017
Merged

netty: fix server keepalive unexpected ping ack #3730

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion netty/src/main/java/io/grpc/netty/NettyServerHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -761,7 +761,8 @@ private final class KeepAlivePinger implements KeepAliveManager.KeepAlivePinger
@Override
public void ping() {
ChannelFuture pingFuture = encoder().writePing(
ctx, false /* isAck */, KEEPALIVE_PING_BUF, ctx.newPromise());
// slice KEEPALIVE_PING_BUF because tls handler may modify the reader index
ctx, false /* isAck */, KEEPALIVE_PING_BUF.slice(), ctx.newPromise());
ctx.flush();
if (transportTracer != null) {
pingFuture.addListener(new ChannelFutureListener() {
Expand Down