core: workaround for Atomic*FieldUpdater bug on some Android devices #3754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericgribkoff
added
the
TODO:backport
| AtomicLongFieldUpdater.newUpdater(ClientTracer.class, "inboundUncompressedSize"); | ||
| } catch (Throwable t) { | ||
| logger.log(Level.WARNING, "Creating atomic field updaters failed", t); | ||
| tmpOutboundMessageCountUpdater = null; |
Contributor
There was a problem hiding this comment.
initialize all these to null above?
Contributor
Author
There was a problem hiding this comment.
Leaving as-is so that all field updater references are assigned a value or they are all null
| tmpInboundUncompressedSizeUpdater = | ||
| AtomicLongFieldUpdater.newUpdater(ClientTracer.class, "inboundUncompressedSize"); | ||
| } catch (Throwable t) { | ||
| logger.log(Level.WARNING, "Creating atomic field updaters failed", t); |
Contributor
There was a problem hiding this comment.
This is probably SEVERE worthy. A core part of the Java API doesn't work.
ejona86
approved these changes
Nov 16, 2017
ejona86
removed
the
TODO:backport
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #3753. Leaves the synchronized fallback in place for SerializingExecutor, but just falls back to (racy) volatile updates in the stats modules.