core: Stabilize ManagedChannelBuilder.overrideAuthority #3761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CallOptions from grpc#1767 are not included, so this is not enough to resolve the issue.
dapengzhang0
approved these changes
Nov 16, 2017
| * | ||
| * <p>Should only used by tests. | ||
| * | ||
| * @return this |
Contributor
There was a problem hiding this comment.
* <p>Should only used by tests. need be revised? The grammar is also incorrect.
Member
Author
|
PTAL |
dapengzhang0
approved these changes
Nov 16, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CallOptions from #1767 are not included, so this is not enough to resolve
the issue.