core: Add negotation timeout for all server transports (backport) #3828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Negotation is the period between transport creation and ready.
handshakeTimeout is unnecessary for InProcess, and the scheduling is causing Thread creation that is breaking restrictive test environments. Those environments are mostly broken already because client-side will try to create Threads as well, but they are currently lucking out that the exception on client-side doesn't break much.
Previously it was 20s. 20s isn't _bad_, but may be too aggressive. Having it longer doesn't hurt us too much; we just need some bound. Since the MAX_BACKOFF on client-side is 120s, this will have client and server match, except for jitter. Although I will note that the client-side value covers more work than the server-side, such as attempting to connect to multiple hosts.
dapengzhang0
approved these changes
Dec 4, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports #3670, #3764, #3799 for the 1.7.x branch.