core: fix Attributes value equality #3859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejona86
reviewed
Dec 11, 2017
Member
ejona86
left a comment
ejona86
left a comment
There was a problem hiding this comment.
Why don't we just swap away from IdentityHashMap?
| if (data.size() != that.data.size()) { | ||
| return false; | ||
| } | ||
| for (Entry<Key<?>, Object> e : data.entrySet()) { |
Member
There was a problem hiding this comment.
This only handles one direction. that.data may contain an extra element, but this would incorrectly say they were equal.
Contributor
Author
There was a problem hiding this comment.
the sizes are checked above
Contributor
Author
|
Identity hashmap is slightly faster. Equals is an uncommon operation, while get and put are common. |
ejona86
approved these changes
Dec 11, 2017
Member
|
While a microbenchmark can possibly notice a minor difference in performance, that level of optimization seems unlikely to matter at all in the greater scheme of things. Instead, it just makes more complicated code and bugs. But whatever. |
Contributor
Author
|
jenkins retest this please |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3857