Skip to content

bazel: fix protobuf sha256 #3924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 8, 2018
Merged

bazel: fix protobuf sha256 #3924

merged 1 commit into from
Jan 8, 2018

Conversation

@jyane
Copy link
Member

@jyane jyane commented Jan 6, 2018 •
edited
Loading

Currently, grpc-java could not build by bazel because protobuf's sha256 is incorrect.
It might need some CI (travis or kokoro(?)) checking.

$ bazel build //protobuf:all
....................
ERROR: /Users/jyane/workspace/repos/github.com/jyane/grpc-java/protobuf/BUILD.bazel:1:1: no such package '@com_google_protobuf_java//': Error downloading [https://github.com/google/protobuf/archive/v3.5.1.zip] to /private/var/tmp/_bazel_jyane/6860dd76b063c3142c2bc69dd88c44cb/external/com_google_protobuf_java/v3.5.1.zip: Checksum was 1f8b9b202e9a4e467ff0b0f25facb1642727cdf5e69092038f15b37c75b99e45 but wanted cef7f1b5a7c5fba672bec2a319246e8feba471f04dcebfe362d55930ee7c1c30 and referenced by '//protobuf:protobuf'
ERROR: /Users/jyane/workspace/repos/github.com/jyane/grpc-java/protobuf/BUILD.bazel:1:1: no such package '@com_google_protobuf_java//': Error downloading [https://github.com/google/protobuf/archive/v3.5.1.zip] to /private/var/tmp/_bazel_jyane/6860dd76b063c3142c2bc69dd88c44cb/external/com_google_protobuf_java/v3.5.1.zip: Checksum was 1f8b9b202e9a4e467ff0b0f25facb1642727cdf5e69092038f15b37c75b99e45 but wanted cef7f1b5a7c5fba672bec2a319246e8feba471f04dcebfe362d55930ee7c1c30 and referenced by '//protobuf:protobuf'
ERROR: Analysis of target '//protobuf:protobuf' failed; build aborted: no such package '@com_google_protobuf_java//': Error downloading [https://github.com/google/protobuf/archive/v3.5.1.zip] to /private/var/tmp/_bazel_jyane/6860dd76b063c3142c2bc69dd88c44cb/external/com_google_protobuf_java/v3.5.1.zip: Checksum was 1f8b9b202e9a4e467ff0b0f25facb1642727cdf5e69092038f15b37c75b99e45 but wanted cef7f1b5a7c5fba672bec2a319246e8feba471f04dcebfe362d55930ee7c1c30
INFO: Elapsed time: 23.761s
FAILED: Build did NOT complete successfully (13 packages loaded)

@jyane jyane mentioned this pull request Jan 6, 2018
Closed
@dapengzhang0 dapengzhang0 added TODO:backport PR needs to be backported. Removed after backport complete kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run labels Jan 8, 2018
@kokoro-team kokoro-team removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Jan 8, 2018
@dapengzhang0 dapengzhang0 merged commit 3b93fd4 into grpc:master Jan 8, 2018
@dapengzhang0 dapengzhang0 added this to the 1.10 milestone Jan 8, 2018
@dapengzhang0
Copy link
Contributor

dapengzhang0 commented Jan 8, 2018

Thanks @jyane for catching the issue.
cc @zhangkun83 for backporting

@jyane jyane deleted the fix-protobuf-sha branch January 9, 2018 00:08
@zhangkun83 zhangkun83 removed the TODO:backport PR needs to be backported. Removed after backport complete label Jan 9, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@dapengzhang0 dapengzhang0 dapengzhang0 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Type: Bug

Projects

None yet

Milestone

1.10

Development

Successfully merging this pull request may close these issues.

4 participants

@jyane @dapengzhang0 @zhangkun83 @kokoro-team