buildscripts: Add Kokoro-based Bazel CI #3933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Using kokoro is much simple I thought was. I have closed #3925. |
Member
Author
|
@jyane, you're not able to see all the changes; there's a little bit of glue internally. But it's about the same complexity of what you see here. I think there are some ways to upload logs to GCS for public viewing, but it requires enough effort that it's worth waiting to see how much pain is being caused first. |
ejona86
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Member
Author
|
The new CI ran and appears to be working. |
Member
Author
|
@zpencer, friendly ping. Should be easy. |
zpencer
approved these changes
Jan 11, 2018
Member
Author
|
Fixed #3502 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internal change is cl/181324357
So... this was really easy (granted, completely untested). But it does have the standard problem of Kokoro of being hard to see externally. I think that's likely "okay" right now, and eventually that limitation should go away. Given there aren't even any tests being run, I hope that just the "failure" signal would be enough for most people.
I'm not against adding bazel to Travis, but it seemed to become a bit of a can of worms, as could be seen in #3925. I think we could make it reasonably clean, but I'm not sure it's worth the effort given how simple this solution is.
CC @jyane