core: change retention policies to CLASS #3994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`@Internal` and `@ExperimentalApi` annotations are not visible at compile time of application (not grpc-java) because their retention policies are `SOURCE`. So, change retention policies to `CLASS`.
dapengzhang0
added
the
kokoro:run
kokoro-team
removed
the
kokoro:run
ericgribkoff
approved these changes
Jan 26, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Internaland@ExperimentalApiannotations are not visible at compile time of application (not grpc-java) because their retention policies areSOURCE.So, change retention policies to
CLASS.According to
javap -v, grpc-java's annotations are removed at compile time.I think changing to
CLASSis necessary for resolving this issue (#3929) because the users will use compiled jar files.If this(#790 (comment)) is the only reason, I want to change retention policy to
CLASS.