netty: only add gRPC negotiator once SSL is established #3997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I confirmed manually that this makes the correct error show up. |
Contributor
|
I confirmed as well. With the addition of this change, I can now see the real SSL exception. |
nddipiazza
pushed a commit
to nddipiazza/grpc-java
that referenced
this pull request
Jan 25, 2018
netty: only add gRPC negotiator once SSL is established # Conflicts: # netty/src/main/java/io/grpc/netty/ProtocolNegotiators.java
ejona86
approved these changes
Jan 25, 2018
ejona86
added
the
TODO:backport
ejona86
removed
the
TODO:backport
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #3991