Skip to content

Conversation

@jiangtaoli2016
Copy link
Contributor

gRPC Java ALTS code. The codes are the same as the internal version, except (1) changes in the import header, and (2) a few minor cosmetics changes such as adding comments on test files to avoid checkstyle errors.

Tested:
./gradlew build
In examples directory, manually tested on a real GCE VM.
./gradlew build
./gradlew installDist
./build/install/examples/bin/hello-world-alts-server
./build/install/examples/bin/hello-world-alts-client

],
cmd = "for fname in $(SRCS); do " +
"sed 's,import \",import \"alts/protobuf_out/,g' $$fname > " +
"$(@D)/protobuf_out/$$(basename $$fname); done",
Copy link
Member

@jyane jyane Feb 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question: Does it work with Windows? Or grpc-java does not support Windows with Bazel?

Same problems will appear other projects (e.g. grpc-services).
Previous discussions are available at here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For windows, you could either use gradle or compile in linux then copy .jar to windows.

Once bazel team has a fix on this problem bazelbuild/bazel#4544, I will remove this genrule.

Copy link
Member

@jyane jyane Feb 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@ejona86 ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Feb 13, 2018
@jiangtaoli2016
Copy link
Contributor Author

It seems that all the tests failures are due to Deprecated method valueOf() called in generated code.
protocolbuffers/protobuf#2054
protocolbuffers/protobuf#4046
It seems that protobuf already suppress the warning in the last trunk. But kokoro still uses older version of protobuf compiler.

@ejona86
Copy link
Member

ejona86 commented Feb 13, 2018

In alts/build.gradle, you can add after configureProtoCompilation():

[compileJava, compileTestJava].each() {
        // protobuf calls valueof. Will be fixed in next release (google/protobuf#4046)
        it.options.compilerArgs += ["-Xlint:-deprecated"]
}

@kokoro-team kokoro-team removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Feb 13, 2018
@jiangtaoli2016 jiangtaoli2016 force-pushed the alts branch 2 times, most recently from 6a9b4dd to a0e45ac Compare February 13, 2018 20:51
@jiangtaoli2016
Copy link
Contributor Author

jiangtaoli2016 commented Feb 13, 2018

All tests are passing.

Copy link
Contributor

@carl-mastrangelo carl-mastrangelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiangtaoli2016 jiangtaoli2016 added the kokoro:force-run Add this label to a PR to tell Kokoro to re-run all tests. Not generally necessary label Feb 15, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to a PR to tell Kokoro to re-run all tests. Not generally necessary label Feb 15, 2018
@carl-mastrangelo carl-mastrangelo merged commit e7f2f1d into grpc:master Feb 15, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants