-
Notifications
You must be signed in to change notification settings - Fork 3.9k
gRPC ALTS #4072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gRPC ALTS #4072
Conversation
| ], | ||
| cmd = "for fname in $(SRCS); do " + | ||
| "sed 's,import \",import \"alts/protobuf_out/,g' $$fname > " + | ||
| "$(@D)/protobuf_out/$$(basename $$fname); done", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a question: Does it work with Windows? Or grpc-java does not support Windows with Bazel?
Same problems will appear other projects (e.g. grpc-services).
Previous discussions are available at here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For windows, you could either use gradle or compile in linux then copy .jar to windows.
Once bazel team has a fix on this problem bazelbuild/bazel#4544, I will remove this genrule.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
|
It seems that all the tests failures are due to Deprecated method |
|
In alts/build.gradle, you can add after |
6a9b4dd to
a0e45ac
Compare
|
All tests are passing. |
carl-mastrangelo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
gRPC Java ALTS code. The codes are the same as the internal version, except (1) changes in the import header, and (2) a few minor cosmetics changes such as adding comments on test files to avoid checkstyle errors.
Tested:
./gradlew build
In examples directory, manually tested on a real GCE VM.
./gradlew build
./gradlew installDist
./build/install/examples/bin/hello-world-alts-server
./build/install/examples/bin/hello-world-alts-client