cronet: delay cast to ExperimentalCronetEngine #4230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We actually require an
ExperimentalCronetEngineto create any streams, but our API previously allowed anyCronetEngineand delayed the cast until an RPC was created. #4208 moved the cast earlier, which broke some internal tests (using mocked CronetEngines) that never actually sent an RPC. We should adjust the API here to require anExperimentalCronetEngineupfront, but this PR restores the delayed cast behavior to fix existing tests, until I have time to update the internal user's test code along with the API change.cc @JensenPaul