Skip to content

core: re-enable panic mode after all affected internal tests have been fixed. #4245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2018
Merged

core: re-enable panic mode after all affected internal tests have been fixed. #4245

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions core/src/main/java/io/grpc/internal/ManagedChannelImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,11 +119,7 @@ final class ManagedChannelImpl extends ManagedChannel implements Instrumented<Ch
@Override
void handleUncaughtThrowable(Throwable t) {
super.handleUncaughtThrowable(t);
// Disabled because it breaks some tests, as it detects pre-existing issues.
// See #3293
if (false) {
panic(t);
}
panic(t);
}
};

Expand Down