cronet: allow application to provide all threads #4249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapengzhang0
force-pushed
the
cronettimer
branch
2 times, most recently
from
ab38b4c to
c84e86a
Compare
dapengzhang0
force-pushed
the
cronettimer
branch
from
c84e86a to
06036c0
Compare
ericgribkoff
approved these changes
Mar 21, 2018
| new TaggingStreamFactory( | ||
| cronetEngine, trafficStatsTagSet, trafficStatsTag, trafficStatsUidSet, trafficStatsUid), | ||
| MoreExecutors.directExecutor(), | ||
| MoreExecutors.directExecutor(), scheduledExecutorService, |
Contributor
There was a problem hiding this comment.
This should be two separate lines
| import io.grpc.MethodDescriptor; | ||
| import io.grpc.cronet.CronetChannelBuilder.CronetTransportFactory; | ||
| import io.grpc.internal.ClientTransportFactory; | ||
| import io.grpc.internal.ConnectionClientTransport; |
| assertSame(builder, builder1); | ||
|
|
||
| ClientTransportFactory clientTransportFactory = builder1.buildTransportFactory(); | ||
|
|
Contributor
There was a problem hiding this comment.
nit: unnecessary empty line
dapengzhang0
commented
Mar 21, 2018
Contributor
Author
dapengzhang0
left a comment
dapengzhang0
left a comment
There was a problem hiding this comment.
Thanks for the review.
| new TaggingStreamFactory( | ||
| cronetEngine, trafficStatsTagSet, trafficStatsTag, trafficStatsUidSet, trafficStatsUid), | ||
| MoreExecutors.directExecutor(), | ||
| MoreExecutors.directExecutor(), scheduledExecutorService, |
| import io.grpc.MethodDescriptor; | ||
| import io.grpc.cronet.CronetChannelBuilder.CronetTransportFactory; | ||
| import io.grpc.internal.ClientTransportFactory; | ||
| import io.grpc.internal.ConnectionClientTransport; |
| assertSame(builder, builder1); | ||
|
|
||
| ClientTransportFactory clientTransportFactory = builder1.buildTransportFactory(); | ||
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the cronet counterpart of #4139 and #4150.