core: make service config errors recoverable #4643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangkun83
reviewed
Jul 20, 2018
Contributor
zhangkun83
left a comment
zhangkun83
left a comment
There was a problem hiding this comment.
LGTM except for a nit.
| } | ||
|
|
||
| private static final class EmptySubchannelPicker extends SubchannelPicker { | ||
| private static final class FailingLoadBalancer extends LoadBalancer { |
Contributor
There was a problem hiding this comment.
Please name by what it does, not by what it used for.
So this is basically a NoopLoadBalancer
zhangkun83
approved these changes
Jul 20, 2018
Contributor
Author
|
GAE already failing, will proceed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4614