core: channel tracing log only when number of backends changed between zeor and nonzero #4666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n zeor and nonzero
zpencer
reviewed
Jul 23, 2018
| @CheckForNull | ||
| private final ChannelTracer channelTracer; | ||
| private final Channelz channelz; | ||
| private Boolean nonzeroBackends; // a flag for doing channel tracing when flipped |
Contributor
There was a problem hiding this comment.
I think this part would be more clear if we created a separate enum for onAddresses and onError, since the goal is to avoid consecutive reports for the same event type.
Contributor
Author
There was a problem hiding this comment.
Per the new spec, error events in general are not logged unless it results in # of backends down to zero from nonzeor. (Both "zero backends resolved" and "general error" are considered # of backends <- zero). A separate enum for error seems overly specific. Maybe the flag can be refactored as "error"?
zpencer
approved these changes
Jul 23, 2018
Contributor
zpencer
left a comment
zpencer
left a comment
There was a problem hiding this comment.
LGTM if we flip the negation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to implement one of changes made in the spec
https://github.com/grpc/proposal/pull/89/files