core: let channel tracing log service config changes #4675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapengzhang0
force-pushed
the
channeltrace4
branch
from
149fa1a to
caf03a5
Compare
zpencer
reviewed
Jul 25, 2018
| private final ChannelTracer channelTracer; | ||
| private final Channelz channelz; | ||
| @CheckForNull | ||
| private Boolean zeroBackends; // a flag for doing channel tracing when flipped |
Contributor
There was a problem hiding this comment.
nit: sorry to bring this up again, but I just realized it might be even more clear if we made this haveBackends since the zero part is still effectively a negation.
zpencer
approved these changes
Jul 25, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the implementation of the second one of the changes to the channel tracing spec
grpc/proposal#89