Skip to content

Conversation

@carl-mastrangelo
Copy link
Contributor

@carl-mastrangelo carl-mastrangelo commented Aug 2, 2018

This is a minor API change, since names can no longer be null. gRPC never constructed these addresses with null, but other users could.

Copy link
Contributor

@zhangkun83 zhangkun83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests?

@carl-mastrangelo
Copy link
Contributor Author

Done

@carl-mastrangelo carl-mastrangelo merged commit 9895e24 into grpc:master Aug 3, 2018
@carl-mastrangelo carl-mastrangelo deleted the ipt branch August 3, 2018 00:28
@lock lock bot locked as resolved and limited conversation to collaborators Nov 1, 2018
@carl-mastrangelo carl-mastrangelo restored the ipt branch August 17, 2019 01:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants