Skip to content

cronet: report statsTraceCtx.clientOutboundHeaders() #4768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 29, 2018
Merged

cronet: report statsTraceCtx.clientOutboundHeaders() #4768

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4c9dd3
cronet: report statsTraceCtx.clientOutboundHeaders()
ericgribkoff Aug 16, 2018
4b82c1c
notify on first write
ericgribkoff Aug 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions cronet/src/main/java/io/grpc/cronet/CronetClientStream.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ class CronetClientStream extends AbstractClientStream {
private static final String LOG_TAG = "grpc-java-cronet";
private final String url;
private final String userAgent;
private final StatsTraceContext statsTraceCtx;
private final Executor executor;
private final Metadata headers;
private final CronetClientTransport transport;
Expand Down Expand Up @@ -98,6 +99,7 @@ class CronetClientStream extends AbstractClientStream {
method.isSafe());
this.url = Preconditions.checkNotNull(url, "url");
this.userAgent = Preconditions.checkNotNull(userAgent, "userAgent");
this.statsTraceCtx = Preconditions.checkNotNull(statsTraceCtx, "statsTraceCtx");
this.executor = Preconditions.checkNotNull(executor, "executor");
this.headers = Preconditions.checkNotNull(headers, "headers");
this.transport = Preconditions.checkNotNull(transport, "transport");
Expand Down Expand Up @@ -221,6 +223,8 @@ class TransportState extends Http2ClientStreamTransportState {
private Status cancelReason;
@GuardedBy("lock")
private boolean readClosed;
@GuardedBy("lock")
private boolean firstWriteComplete;

public TransportState(
int maxMessageSize, StatsTraceContext statsTraceCtx, Object lock,
Expand Down Expand Up @@ -418,6 +422,12 @@ public void onWriteCompleted(BidirectionalStream stream, UrlResponseInfo info,
Log.v(LOG_TAG, "onWriteCompleted");
}
synchronized (state.lock) {
if (!state.firstWriteComplete) {
// Cronet API doesn't notify when headers are written to wire, but it occurs before first
// onWriteCompleted callback.
state.firstWriteComplete = true;
statsTraceCtx.clientOutboundHeaders();
}
state.onSentBytes(buffer.position());
}
}
Expand Down