services: disallow duplicate rules for a binlogging services or methods #4868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejona86
approved these changes
Sep 21, 2018
| } | ||
| perServiceLogs.put(service, binLog); | ||
| checkState( | ||
| !perServiceLogs.containsKey(service), |
Member
There was a problem hiding this comment.
It seems we also need to check blacklistedMethods. Otherwise we could add the negative method first and then this positive method.
Contributor
Author
There was a problem hiding this comment.
This section is for per service policies like "service/*{h}" which defines a default config for all sub-methods not explicitly configured. Added some clarifying comments.
Let's simplify the impementation to just disallow duplicates. This makes it easier to maintain. Background info: grpc/proposal#104
zpencer
force-pushed
the
binlog-duplicate-rules
branch
from
7387e22 to
f73cedf
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's simplify the implementation to just disallow duplicates. This
makes it easier to maintain.
Background info: grpc/proposal#104