Skip to content

Conversation

@creamsoup
Copy link
Contributor

AsyncFrameWriter quietly log when socket is already closed.
also, default log level down to INFO which is same as NettyServerTransport.

resolves #3046

…ed. also, default log level down to INFO which is same as NettyServerTransport.
Copy link
Contributor

@carl-mastrangelo carl-mastrangelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@creamsoup creamsoup merged commit c0a3c4a into grpc:master Oct 10, 2018
@creamsoup creamsoup deleted the quieterror branch October 10, 2018 00:12
@lock lock bot locked as resolved and limited conversation to collaborators Jan 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OkHttp exception logging level too high?

2 participants