xds: allow grpclb balancer addresses for backward compatibility #5823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This work is done in the XdsLoadBalancer -- doesn't it require client to be upgraded to xDS in the first place? |
zhangkun83
reviewed
Jun 6, 2019
| LbConfig fallbackPolicy) { | ||
| this.fallbackServers = servers; | ||
| String fallbackPolicyName = fallbackPolicy.getPolicyName(); | ||
| if (!fallbackPolicyName.equals("grpclb") && !fallbackPolicyName.equals(XDS_POLICY_NAME)) { |
There was a problem hiding this comment.
Probably worth a comment here.
zhangkun83
approved these changes
Jun 6, 2019
zhangkun83
reviewed
Jun 7, 2019
| servers = backends.build(); | ||
| } | ||
|
|
||
| // FIXME: this is a temporary hack. |
There was a problem hiding this comment.
Please add TODO(zhangkun83) and refer to #5496
| } | ||
| } | ||
|
|
||
| private void handleFallbackAddressesOrNameResolutionError() { |
There was a problem hiding this comment.
Why does the method name contain "NameResolutionError"? It's only called from fallback-related methods. What this method does is passing the latest fallback addresses to the fallback balancer. The handling of empty addresses is just part of it. Maybe "propagateFallbackAddresses()".
zhangkun83
approved these changes
Jun 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During migration, the name resolver may not know when the client has been upgraded to xds, so it may still send grpclb v1 addresses with a list of policies including both grpclb v1 and xds.