Fix java path separator bug on Windows #6054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement. After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.
Regards, |
|
Hey @thelinuxfoundation bot, I signed the CLA. |
ejona86
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
ejona86
approved these changes
Aug 13, 2019
|
Thank you for the helpful description. Made it easy to see what's going on. Sorry for the bug! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
java_grpc_librarytargets based onjava_proto_librarytargets with more than oneproto_librarydependency can't be built on Windows, starting somewhere before 1.22. A minimal reproducing example is available on https://github.com/Xjs/bazel-grpc-java-win-repro (seeREADME.mdthere for output on my machine as well as steps to reproduce).The issue stems from
protocconfiguring a different path separator for Windows at compile time in combination withjava_grpc_libraryalways using:.This PR uses the path separator available from the bazel context's host_configuration to resolve the issue.