Skip to content

cronet: add grpc-cronet artifact publishing configurations #6130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 9, 2019
Merged

cronet: add grpc-cronet artifact publishing configurations #6130

merged 4 commits into from
Sep 9, 2019

Conversation

voidzcy
Copy link
Contributor

@voidzcy voidzcy commented Sep 6, 2019 •
edited
Loading

  • Added maven publish plugin and configurations.
  • Changed grpc-cronet minSdkVersion to 16 as cronet dependency requires so.
  • Changed cronet dependency configuration, grpc-cronet now only has dependency on cronet-api, which contains only the API layer of cronet without implementation providers. Cronet implementation is still needed for tests.

@voidzcy voidzcy requested a review from ejona86 September 6, 2019 21:11
@ejona86 ejona86 mentioned this pull request Sep 7, 2019
Merged
@voidzcy voidzcy merged commit 2671a3d into grpc:master Sep 9, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ejona86 ejona86 ejona86 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@voidzcy @ejona86