Add OkHttp-based server #9177
Merged
Add OkHttp-based server #9177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
temawi
reviewed
May 23, 2022
Member
Author
|
This needs to be rebased for the CI to be happy. I'll coordinate to determine when to do so. |
temawi
approved these changes
Jun 29, 2022
YifeiZhuang
approved these changes
Jun 29, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs more tests, but it actually passes AbstractTransportTest and AbstractInteropTest with okhttp and netty clients.I do think I can split out some of the changes to existing code to make it more clear why those are made. So don't look too closely at them right now.
CC @temawi @YifeiZhuang