Skip to content

Move the initial call.request #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Move the initial call.request #282

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
75b5ea5
Move the initial call.request
taer Aug 12, 2021
feb3f7a
Merge branch 'master' into moveRequest
taer Sep 28, 2022
8a648c6
Merge branch 'master' into moveRequest
taer Jan 17, 2023
5a54331
Merge branch 'master' into moveRequest
taer Mar 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion stub/src/main/java/io/grpc/kotlin/ServerCalls.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,6 @@ object ServerCalls {
"requests flow can only be collected once"
}

call.request(1)
Copy link
Contributor Author

@taer taer Aug 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is inside the flow

try {
for (request in requestsChannel) {
emit(request)
Expand Down Expand Up @@ -268,6 +267,8 @@ object ServerCalls {
mutex.withLock { call.close(closeStatus, trailers) }
}

call.request(1)
Copy link
Contributor Author

@taer taer Aug 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved outside the flow. Made it a bit more eager.


return object: ServerCall.Listener<RequestT>() {
var isReceiving = true

Expand Down