-
Notifications
You must be signed in to change notification settings - Fork 435
Closed
Description
The CgRPC and NIO variants are disjoint (well, almost: StatusCode.swift and echo.proto are shared) but live in the same Swift package and repository.
This has a couple of drawbacks:
- Both are tied to the same Swift version.
- They share a build system and CI.
In the NIO implementation we would like to use a newer version of swift-nio-http2 to drop the nghttp2 dependency. Doing this requires using NIO 2.0 which is Swift 5 only.
Two obvious approaches are:
- separate repositories (i.e. "grpc-swift" and "grpc-swift-nio"), and
- separate branches (with different major versions).
Part of this rests on how long the CgRPC implementation will be around. If support is dropped in favour of the NIO implementation then separate branches with different major release versions should be fine. If both are supported long term then separate repositories would probably make more sense since they are separate projects.
Metadata
Metadata
Assignees
Labels
No labels