some tests are timing sensitive and they usually fail for me in docker

[weissi]

some tests are timing sensitive and they usually fail for me in docker. Likely, there's not much that we can do except for offering a way to disable them. I'd suggest an env var

ENABLE_TIMING_TESTS=false

that would disable them. Attached the failure trace. Head is

$ head /tmp/test-unary-lots.txt
Test Case 'NIOFunctionalTestsAnonymousClient.testUnaryLotsOfRequests' started at 2019-04-17 11:04:39.318



1000 requests sent so far, elapsed time: 17.819645
total time to send 2000 requests: 62.545991
/Users/johannes/.Trash/.nio-release-tools_WPakBo/grpc-swift/Tests/SwiftGRPCNIOTests/NIOFunctionalTests.swift:97: error: NIOFunctionalTestsAnonymousClient.testUnaryLotsOfRequests : failed - Expecteded 'SwiftGRPCNIOTests.Echo_EchoResponse:
text: "Swift echo get: foo 400"
' but received error: GRPCStatus(code: SwiftGRPCNIO.StatusCode.deadlineExceeded, message: Optional("call exceeded timeout of 1 M"), trailingMetadata: [])
/Users/johannes/.Trash/.nio-release-tools_WPakBo/grpc-swift/Tests/SwiftGRPCNIOTests/NIOFunctionalTests.swift:98: error: NIOFunctionalTestsAnonymousClient.testUnaryLotsOfRequests : XCTAssertEqual failed: ("ok") is not equal to ("deadlineExceeded") - 

test-unary-lots.txt

environment:

swift:5.0 docker image with these versions and gprpc-commit 283754e

root@b4a7ae06c069:/Users/johannes/.Trash/.nio-release-tools_WPakBo/grpc-swift# cat Package.resolved 
{
  "object": {
    "pins": [
      {
        "package": "Commander",
        "repositoryURL": "https://github.com/kylef/Commander.git",
        "state": {
          "branch": null,
          "revision": "e5b50ad7b2e91eeb828393e89b03577b16be7db9",
          "version": "0.8.0"
        }
      },
      {
        "package": "Spectre",
        "repositoryURL": "https://github.com/kylef/Spectre.git",
        "state": {
          "branch": null,
          "revision": "f14ff47f45642aa5703900980b014c2e9394b6e5",
          "version": "0.9.0"
        }
      },
      {
        "package": "swift-nio",
        "repositoryURL": "https://github.com/apple/swift-nio.git",
        "state": {
          "branch": null,
          "revision": "b8368b6e09b7993896c42a6199103a73ecc1dbf9",
          "version": "2.0.0"
        }
      },
      {
        "package": "swift-nio-http2",
        "repositoryURL": "https://github.com/apple/swift-nio-http2.git",
        "state": {
          "branch": null,
          "revision": "a92923bcb7d884e6977b7cb131705703936af956",
          "version": "1.0.1"
        }
      },
      {
        "package": "swift-nio-ssl",
        "repositoryURL": "https://github.com/apple/swift-nio-ssl.git",
        "state": {
          "branch": null,
          "revision": "47d971e1367f6df8ddf06c284ad266df39c31024",
          "version": "2.0.1"
        }
      },
      {
        "package": "swift-nio-ssl-support",
        "repositoryURL": "https://github.com/apple/swift-nio-ssl-support.git",
        "state": {
          "branch": null,
          "revision": "c02eec4e0e6d351cd092938cf44195a8e669f555",
          "version": "1.0.0"
        }
      },
      {
        "package": "swift-nio-zlib-support",
        "repositoryURL": "https://github.com/apple/swift-nio-zlib-support.git",
        "state": {
          "branch": null,
          "revision": "37760e9a52030bb9011972c5213c3350fa9d41fd",
          "version": "1.0.0"
        }
      },
      {
        "package": "SwiftProtobuf",
        "repositoryURL": "https://github.com/apple/swift-protobuf.git",
        "state": {
          "branch": null,
          "revision": "6520fb185db88c0774a929acea1f7d5981a30d3a",
          "version": "1.4.0"
        }
      }
    ]
  },
  "version": 1
}
root@b4a7ae06c069:/Users/johannes/.Trash/.nio-release-tools_WPakBo/grpc-swift# 

[MrMage]

@weissi just to be sure, did you run this with Cory's recent Heap performance fixes? That might alleviate things a bit. But we should of course find a proper solution for this, too — either increasing timeouts or skipping those tests in that case.

[weissi]

I think either way we need a way to disable the timing sensitive tests, docker is just so slow sometimes...