Fix 0.9.1 Carthage Support on Xcode 12.2 #1053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
approved these changes
Nov 24, 2020
Collaborator
glbrntt
left a comment
glbrntt
left a comment
There was a problem hiding this comment.
I think this looks fine.
|
@glbrntt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1051
Xcode 12 (Xcode 12.2) has some build issues when
SwiftGRPC-Carthage.xcodeprojruns its pre-action script. the script executesswift package resolveand is affected by some env when it's build on Xcode 12.x.This PR applies a workaround for that. In addition, Swift Package Manager in Xcode 12 generates a different filename in the intermediate .build folder (.build/dependencies-state.json -> .build/workspace-state.json). This PR also fixes it.
grpc-swift may require Xcode 12.x after this PR is merged.