Use sync options to get the http2 stream ID #1229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
force-pushed
the
gb-stream-id-sync
branch
from
6b15298 to
0bb73e7
Compare
Davidde94
approved these changes
Jul 21, 2021
Contributor
Davidde94
left a comment
Davidde94
left a comment
There was a problem hiding this comment.
Some nits, otherwise looks good.
Motivation: NIO added API for getting channel options synchronously. NIO HTTP/2 added support for this in 1.17.0. When configuring a server we configure our new stream channels to get the stream ID to attach to the loggers. We can now do this synchronously and save some allocations. Modifications: - Bump minimum H2 version to 1.17.0 - Use sync options to get the stream ID and sync pipeline operations to add the handler. - Modify alloc-limits.sh so format better aligns with new CI yaml Result: Fewer allocations.
glbrntt
force-pushed
the
gb-stream-id-sync
branch
from
0bb73e7 to
3a73c69
Compare
Davidde94
reviewed
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
NIO added API for getting channel options synchronously. NIO HTTP/2
added support for this in 1.17.0. When configuring a server we configure
our new stream channels to get the stream ID to attach to the loggers.
We can now do this synchronously and save some allocations.
Modifications:
add the handler.
Result:
Fewer allocations.