Use more specific NIO imports #1239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The `NIO` module is now a 'shell' module which re-exports `NIOCore`, `NIOPosix` and `NIOEmbeeded`. Modifications: For the GRPC and GRPCTests modules: - Replace "import NIO" with "import NIOCore" - Add imports for NIOEmbeeded and NIOPosix as necessary Result: Imports are closer to what we actually use.
fabianfett
reviewed
Aug 19, 2021
| .product(name: "NIO", package: "swift-nio"), | ||
| .product(name: "NIOCore", package: "swift-nio"), | ||
| .product(name: "NIOPosix", package: "swift-nio"), | ||
| .product(name: "NIOEmbedded", package: "swift-nio"), |
Collaborator
There was a problem hiding this comment.
I know that this is to setup a client for a throughput test, but linking NIOEmbedded looks wrong :) maybe we can change this with a follow up PR.
Collaborator
Author
There was a problem hiding this comment.
Sadly it's more than that: the test clients also make use of EmbeddedChannel.
fabianfett
approved these changes
Aug 19, 2021
Collaborator
fabianfett
left a comment
fabianfett
left a comment
There was a problem hiding this comment.
We should really try to not link NIOEmbedded in GRPC in the future
glbrntt
added a commit
to glbrntt/grpc-swift
that referenced
this pull request
Aug 19, 2021
Motivation: The `NIO` module is now a 'shell' module which re-exports `NIOCore`, `NIOPosix` and `NIOEmbeeded`. Modifications: For the GRPC and GRPCTests modules: - Replace "import NIO" with "import NIOCore" - Add imports for NIOEmbeeded and NIOPosix as necessary Result: Imports are closer to what we actually use. (cherry picked from commit c88f038)
glbrntt
added a commit
that referenced
this pull request
Aug 19, 2021
Motivation: The `NIO` module is now a 'shell' module which re-exports `NIOCore`, `NIOPosix` and `NIOEmbeeded`. Modifications: For the GRPC and GRPCTests modules: - Replace "import NIO" with "import NIOCore" - Add imports for NIOEmbeeded and NIOPosix as necessary Result: Imports are closer to what we actually use. (cherry picked from commit c88f038)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The
NIOmodule is now a 'shell' module which re-exportsNIOCore,NIOPosixandNIOEmbeeded.Modifications:
For the GRPC and GRPCTests modules:
Result:
Imports are closer to what we actually use.