Raise the default HTTP/2 target window size #1248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianfett
approved these changes
Aug 25, 2021
Collaborator
fabianfett
left a comment
fabianfett
left a comment
There was a problem hiding this comment.
LGTM. 8MB is exactly the value that Cory proposed for AHC.
Motivation: The default flow control window size is 64kb which is quite small. As a result connections may spend longer than necessary waiting for window updates. Modifications: Increase the target window size to 8MB. Result: HTTP target window size is 8MB by default.
glbrntt
force-pushed
the
gb-larger-default-window-size
branch
from
8946ee2 to
6e1f90a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The default flow control window size is 64kb which is quite small. As a
result connections may spend longer than necessary waiting for
window updates.
Modifications:
Increase the target window size to 8MB.
Result:
HTTP target window size is 8MB by default.