Add 'cause' to more transformed statuses #1306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: In grpc#1290 a 'cause' was added to `GRPCStatus` so use have access the error which resulted in the status. We use the `GRPCStatusTransformable` protocol to transform errors to statuses, but we missed adding passing along the cause in a bunch of places. Modifications: - Add a cause to the status for a handful of additional error types Result: More errors provide a cause when converted to a status
bimawa
pushed a commit
to StreamLayer/grpc-swift
that referenced
this pull request
Nov 10, 2021
Motivation: In grpc#1290 a 'cause' was added to `GRPCStatus` so use have access the error which resulted in the status. We use the `GRPCStatusTransformable` protocol to transform errors to statuses, but we missed adding passing along the cause in a bunch of places. Modifications: - Add a cause to the status for a handful of additional error types Result: More errors provide a cause when converted to a status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
In #1290 a 'cause' was added to
GRPCStatusso use have access the errorwhich resulted in the status. We use the
GRPCStatusTransformableprotocol to transform errors to statuses, but we missed adding passing
along the cause in a bunch of places.
Modifications:
Result:
More errors provide a cause when converted to a status