Extend interoperability tests to use async provider #1312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The interoperability tests exercise a well-defined sequence of requests for all implementations of gRPC. We already had interop tests for the ELG-based client and provider. This pull request extends the tests to exercise an async-await–based provider.
simonjbeaumont
commented
Nov 12, 2021
| /// | ||
| /// See: https://github.com/grpc/grpc/blob/master/doc/interop-test-descriptions.md#server | ||
| @available(macOS 12, iOS 15, tvOS 15, watchOS 8, *) | ||
| public class TestServiceAsyncProvider: Grpc_Testing_TestServiceAsyncProvider { |
Collaborator
Author
There was a problem hiding this comment.
Note: this class attempts to be be a like-for-like translation of TestServiceProvider.
glbrntt
approved these changes
Nov 15, 2021
Collaborator
glbrntt
left a comment
glbrntt
left a comment
There was a problem hiding this comment.
One nit but looks great otherwise, thanks Si!
Sources/GRPCInteroperabilityTestsImplementation/TestServiceAsyncProvider.swift
Outdated
Show resolved
Hide resolved
Signed-off-by: Si Beaumont <beaumont@apple.com>
glbrntt
approved these changes
Nov 15, 2021
glbrntt
pushed a commit
that referenced
this pull request
Nov 26, 2021
The interoperability tests exercise a well-defined sequence of requests for all implementations of gRPC. We already had interop tests for the ELG-based client and provider. This pull request extends the tests to exercise an async-await–based provider. Signed-off-by: Si Beaumont <beaumont@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interoperability tests exercise a well-defined sequence of requests
for all implementations of gRPC. We already had interop tests for the
ELG-based client and provider. This pull request extends the tests to
exercise an async-await–based provider.