Skip to content

Conversation

@glbrntt
Copy link
Collaborator

@glbrntt glbrntt commented Dec 20, 2021

Motivation:

Swift 5.5.2 includes XCTest support for async/await. Currently we are
working around the lack of support with XCTest expectations.

Modifications:

  • Remove the helper
  • Make async tests async throws

Result:

Fewer workarounds.

@glbrntt glbrntt added the semver/none No version bump required. label Dec 20, 2021
Motivation:

Swift 5.5.2 includes XCTest support for async/await. Currently we are
working around the lack of support with XCTest expectations.

Modifications:

- Remove the helper
- Make async tests `async throws`

Result:

Fewer workarounds.
Copy link
Collaborator

@fabianfett fabianfett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! ❤️

@glbrntt glbrntt merged commit 8fcf4f3 into grpc:1.6.0-async-await Dec 20, 2021
@glbrntt glbrntt deleted the gb-async-tests branch December 20, 2021 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver/none No version bump required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants