Add new Timeout type #1718
Merged
Add new Timeout type #1718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjcairo
commented
Nov 23, 2023
FranzBusch
reviewed
Nov 24, 2023
dnadoba
reviewed
Nov 24, 2023
gjcairo
force-pushed
the
timeout-coding
branch
from
f512123 to
c1cc4d7
Compare
glbrntt
requested changes
Nov 27, 2023
gjcairo
force-pushed
the
timeout-coding
branch
from
6fa4065 to
df4774c
Compare
glbrntt
approved these changes
Nov 27, 2023
Collaborator
glbrntt
left a comment
glbrntt
left a comment
There was a problem hiding this comment.
One nit, looks good otherwise!
gjcairo
force-pushed
the
timeout-coding
branch
from
0b47a28 to
d0fc215
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We need an encodable/decodable
Timeouttype to represent gRPC timeouts.Modification
Added a new
Timeouttype that can be encoded to and from aStringwith the format specified by gRPC.Result
We now have a way to represent
Timeouts.