Add SourceFile type for CodeGenLib #1723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y the code generator. Motivation: The CodeRenderer needs to create objects of some type representing the files containing the generated code. This type is SourceFile. Modifications: Implemented the SourceFile struct, containing a name as a String and the generated code as Data. Result: The Code Renderer can now be brought from the OpenAPI generator, as it will have an output type. The code generator will use objects of this type to create the files containing the generated Swift code.
glbrntt
reviewed
Nov 27, 2023
Sources/GRPCCodeGen/SourceFile.swift
Outdated
|
|
||
| /// Representation of the file to be created by the code generator, that contains the | ||
| /// generated Swift source code. | ||
| public struct SourceFile: Sendable { |
Collaborator
There was a problem hiding this comment.
This should be Hashable too
Sources/GRPCCodeGen/SourceFile.swift
Outdated
| public var name: String | ||
|
|
||
| /// The generated code as a String. | ||
| public var sourceCode: String |
glbrntt
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created the SorceFile struct that represents the file to be created by the code generator.
Motivation:
The CodeRenderer needs to create objects of some type representing the files containing the
generated code. This type is SourceFile.
Modifications:
Implemented the SourceFile struct, containing the base name and the generated code as strings.
Result:
The Code Renderer can now be brought from the OpenAPI generator, as it will have an output type.
The code generator will use objects of this type to create the files containing the generated Swift code.