Update StructuredSwiftRepresentation #1725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PI generator. Motivation: The latest version of the Code Renderer uses the Expression type for the `left` property of a VariableDescription, so we need to also update the StructuredSwiftRepresentation accordingly. Result: We will have the latest version of StructuredSwiftRepresentation for the new CodeGenLib.
stefanadranca
changed the title
glbrntt
requested changes
Nov 29, 2023
| /// | ||
| /// For example: `public`. | ||
| enum AccessModifier: String, Equatable, Codable { | ||
| public enum AccessModifier: String, Sendable, Equatable, Codable { |
Collaborator
There was a problem hiding this comment.
We should keep this internal
Collaborator
Author
There was a problem hiding this comment.
Should all of the structs and enums from this file be internal?
Collaborator
There was a problem hiding this comment.
They should be no more visible than internal, fine if some are fileprivate/private. There shouldn't be any public types though.
glbrntt
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update StructuredSwiftRepresentation to the latest version from OpenAPI generator.
Motivation:
The latest version of the Code Renderer uses the Expression type for the
leftproperty of a VariableDescription, so we need to also update the StructuredSwiftRepresentation accordingly.Result:
We will have the latest version of StructuredSwiftRepresentation for the new CodeGenLib.