Brought CodeRenderer from OpenAPI Generator. #1728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Provides an API which takes Structured Swift Representation of a file and generates an object containing the generated code as a String. Modifications: - Brought over RendererProtocol and TextBasedRenderer. - Brought over unit tests in Test_TextBasedRenderer. - Fixed TypeName bugs that produced errors while building. Result: The CodeGenLib will have a code renderer that transforms `StructuredSwiftRepresentation` into `SourceFile`.
glbrntt
reviewed
Nov 29, 2023
| @@ -0,0 +1,781 @@ | |||
| /* | |||
Collaborator
There was a problem hiding this comment.
GRPCTests are tests for v1. Since GPRCCodeGen is a new target for v2, it should have its own corresponding test target GRPCCodeGenTests.
glbrntt
reviewed
Nov 29, 2023
Package.swift
Outdated
| .nioTransportServices, | ||
| .logging, | ||
| .reflectionService, | ||
| .grpcCodeGen |
Package.swift
Outdated
| .protocGenGRPCSwift, | ||
| .grpcSwiftPlugin, | ||
| .reflectionService, | ||
| .grpcCodeGen, |
Collaborator
There was a problem hiding this comment.
nit: move this down to the // v2 section below .grpcCore.
| @@ -0,0 +1,781 @@ | |||
| /* | |||
Collaborator
There was a problem hiding this comment.
re: filename, I know you copy-pasted from OpenAPI, but naming is generally <Foo>Tests.swift, this should be TextBasedRendererTests.swift. We're also trying to keep the hierarchy of library and test code the same so it should be GRPCCodeGenTests/Internal/Renderer/TextBasedRendererTests.swift.
glbrntt
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Provides an API which takes Structured Swift Representation of a file and generates an object containing the generated code as a String.
Modifications:
Result:
The CodeGenLib will have a code renderer that transforms
StructuredSwiftRepresentationintoSourceFile.