Make the retry throttle optional #1734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The retry throttle should be optional, it's currently required by the client transport API. The in-process transport also defaults the throttle without allowing callers to configure it. Modifications: - Make the retry throttle an optional requirement on client transport - Allow callers to configure the retry throttle for the in-process client transport - Add `async throws` to one of the in-process server transport methods, while not necessary, the protocol allows it and we may want to change the implementation in the future. Result: Retry throttle is optional and configurable for the in-process transport
FranzBusch
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The retry throttle should be optional, it's currently required by the client transport API.
The in-process transport also defaults the throttle without allowing callers to configure it.
Modifications:
async throwsto one of the in-process server transport methods, while not necessary, the protocol allows it and we may want to change the implementation in the future.Result:
Retry throttle is optional and configurable for the in-process transport