[CodeGenLib] Typealias translator configuration for client and server #1750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… typealiases Motivation: The typealias translator should generate typealias for the client and server protocols only if the associated code (client/server code) will be generated as well. Also, at the moment the Typealias translator doesn't generate the ClientProtocol typealias. Modifications: - added a new initialiser for the TypealiasTranslator that sets the client and server property. - Based on the client and server properties' values the typealias translator generates or not the protocol typealiases. - created method gor client protocol typalias generation. - modified tests, so they include the client code. - added new tests for generating only client or server code. Result: The typealias translator will generate typealiases for client and server protocols only when the associated code is also generated, getting rid of the possibility of an error (when the protocol doesn't exist).
stefanadranca
commented
Dec 21, 2023
Comment on lines
330
to
334
| let namespacedPrefix: String | ||
| if service.namespace.isEmpty { | ||
| namespacedPrefix = service.name | ||
| } else { | ||
| namespacedPrefix = "\(service.namespace)_\(service.name)" |
Collaborator
Author
There was a problem hiding this comment.
After merging the server code translator PR, I will use the service property from the extension to get the namespacedPrefix
glbrntt
requested changes
Dec 21, 2023
| static let methods: [MethodDescriptor] = [] | ||
| typealias StreamingServiceProtocol = namespaceA_ServiceAServiceStreamingProtocol | ||
| typealias ServiceProtocol = namespaceA_ServiceAServiceProtocol | ||
| typealias ClientProtocol = namespaceA_ServiceAClientProtocol |
Collaborator
There was a problem hiding this comment.
We can add a typealias for the Client as well
Collaborator
Author
There was a problem hiding this comment.
for the struct?
glbrntt
approved these changes
Dec 21, 2023
glbrntt
pushed a commit
to glbrntt/grpc-swift
that referenced
this pull request
Feb 5, 2024
…grpc#1750) Motivation: The typealias translator should generate typealias for the client and server protocols only if the associated code (client/server code) will be generated as well. Also, at the moment the Typealias translator doesn't generate the ClientProtocol typealias. Modifications: - added a new initialiser for the TypealiasTranslator that sets the client and server property. - Based on the client and server properties' values the typealias translator generates or not the protocol typealiases. - created method gor client protocol typalias generation. - modified tests, so they include the client code. - added new tests for generating only client or server code. Result: The typealias translator will generate typealiases for client and server protocols only when the associated code is also generated, getting rid of the possibility of an error (when the protocol doesn't exist).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typealias translator configuration for client and server type aliases
Motivation:
The typealias translator should generate typealiases for the client and server protocols only if the associated code (client/server code) will be generated. Also, at the moment the typealias translator doesn't generate the
ClientProtocoltypealias.Modifications:
TypealiasTranslatorthat sets the client and server property.Result:
The typealias translator will generate typealiases for client and server protocols only when the associated code is also generated, getting rid of the possibility of an error (when the protocol doesn't exist).