Skip to content

Conversation

@gjcairo
Copy link
Collaborator

@gjcairo gjcairo commented Jan 11, 2024

Motivation

We will write an HTTP2 transport for gRPC v2. We need to create some new modules to organise our code.

Modifications

Created new targets and test targets:

  • GRPCHTTP2Core[Tests]
  • GRPCHTTP2TransportNIOPosix[Tests]
  • GRPCHTTP2TransportNIOTransportServices[Tests]

Result

Modules in place so we can start writing the H2 transport.

@gjcairo gjcairo marked this pull request as ready for review January 11, 2024 14:30
)

static let grpcHTTP2TransportNIOTransportServicesTests: Target = .testTarget(
name: "GRPCHTTP2TransportNIOTransportServicesTests",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's quite the name... 😬 we may want to revisit these in the future.

@glbrntt glbrntt added the version/v2 Relates to v2 label Jan 12, 2024
@glbrntt glbrntt merged commit da5a236 into grpc:main Jan 12, 2024
@gjcairo gjcairo deleted the h2-modules branch January 12, 2024 14:17
glbrntt pushed a commit to glbrntt/grpc-swift that referenced this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

version/v2 Relates to v2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants