Add missing compiler directive to ClientCodeTranslatorSnippetBasedTests #1758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts.swift Motivation: A missing compiler directive to avoid compiling the snippet-based tests in non-macOS/Linux platforms was causing the build to fail on iOS/tvOS/watchOS. Modifications: Add the compiler directive. Result: Builds won't fail again in iOS/tvOS/watchOS.
glbrntt
approved these changes
Jan 15, 2024
glbrntt
pushed a commit
to glbrntt/grpc-swift
that referenced
this pull request
Feb 5, 2024
…ts (grpc#1758) Motivation: A missing compiler directive to avoid compiling the snippet-based tests in non-macOS/Linux platforms was causing the build to fail on iOS/tvOS/watchOS. Modifications: Add the compiler directive. Result: Builds won't fail again in iOS/tvOS/watchOS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
A compiler directive that avoids compiling the snippet-based tests in non-macOS/Linux platforms is missing, causing the build to fail on iOS/tvOS/watchOS.
Modifications:
Added the compiler directive.
Result:
Builds won't fail again in iOS/tvOS/watchOS.