Skip to content

Add a handler for managing connections on the server #1762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 22, 2024
Merged

Add a handler for managing connections on the server #1762

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0a604db
Add a handler for managing connections on the server
glbrntt Jan 16, 2024
f358a15
Apply suggestions from code review
glbrntt Jan 22, 2024
17ef28c
Merge branch 'main' into server-connection-handler
glbrntt Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,10 @@ extension Target {
static let grpcHTTP2CoreTests: Target = .testTarget(
name: "GRPCHTTP2CoreTests",
dependencies: [
.grpcHTTP2Core
.grpcHTTP2Core,
.nioCore,
.nioHTTP2,
.nioEmbedded,
]
)

Expand Down
19 changes: 0 additions & 19 deletions Sources/GRPCHTTP2Core/Server/Connection/ServerConnectionHandler.swift
View file
Open in desktop

This file was deleted.

9 changes: 4 additions & 5 deletions ...erverConnectionHandler+StateMachine.swift → ...ctionManagementHandler+StateMachine.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
import NIOCore
import NIOHTTP2

extension ServerConnectionHandler {
extension ServerConnectionManagementHandler {
/// Tracks the state of TCP connections at the server.
///
/// The state machine manages the state for the graceful shutdown procedure as well as policing
Expand Down Expand Up @@ -248,7 +248,7 @@ extension ServerConnectionHandler {
}
}

extension ServerConnectionHandler.StateMachine {
extension ServerConnectionManagementHandler.StateMachine {
fileprivate struct KeepAlive {
/// Allow the client to send keep alive pings when there are no active calls.
private let allowWithoutCalls: Bool
Expand All @@ -267,8 +267,7 @@ extension ServerConnectionHandler.StateMachine {
/// alive (a low number of strikes is therefore expected and okay).
private var pingStrikes: Int

/// The last time a valid ping happened. This may be in the distant past if there is no such
/// time (for example the connection is new and there are no active calls).
/// The last time a valid ping happened.
///
/// Note: `distantPast` isn't used to indicate no previous valid ping as `NIODeadline` uses
/// the monotonic clock on Linux which uses an undefined starting point and in some cases isn't
Expand Down Expand Up @@ -320,7 +319,7 @@ extension ServerConnectionHandler.StateMachine {
}
}

extension ServerConnectionHandler.StateMachine {
extension ServerConnectionManagementHandler.StateMachine {
fileprivate enum State {
/// The connection is active.
struct Active {
Expand Down
Loading