Add compression logic to GRPCMessageFramer
#1771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
glbrntt
reviewed
Jan 24, 2024
gjcairo
force-pushed
the
framer-compression
branch
from
bf68f0b to
04bae73
Compare
glbrntt
approved these changes
Jan 24, 2024
Collaborator
glbrntt
left a comment
glbrntt
left a comment
There was a problem hiding this comment.
Looks good modulo one nit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In #1768 we added a
GRPCMessageFramerto frame messages with gRPC's metadata. This type should also take care of compressing the payloads, if so configured.Modifications
This PR adds compression logic to the
GRPCMessageFramer.## Result
If set up to do so, payloads will now be compressed by the
GRPCMessageFramer.