Add a handler for managing client side keepalive #1773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Clients can be configured to use keepalive which periodically sends PING frames to the server, typically only if streams are open, but this behaviour is configurable. Clients should also close connections after periods of inactivity (if no streams are open). Modifications: Add a client channel handler and state machine which handles client side keepalive and connection idling. The handler also emits connection events to the next handler, these events can be used to determine whether to take the connection out of service (i.e. stop creating new streams on it). Results: The client can manage keepalive and connection idling.
gjcairo
requested changes
Jan 26, 2024
Tests/GRPCHTTP2CoreTests/Client/Connection/ClientConnectionHandlerStateMachineTests.swift
Outdated
Show resolved
Hide resolved
glbrntt
added a commit
to glbrntt/grpc-swift
that referenced
this pull request
Feb 5, 2024
Motivation: Clients can be configured to use keepalive which periodically sends PING frames to the server, typically only if streams are open, but this behaviour is configurable. Clients should also close connections after periods of inactivity (if no streams are open). Modifications: Add a client channel handler and state machine which handles client side keepalive and connection idling. The handler also emits connection events to the next handler, these events can be used to determine whether to take the connection out of service (i.e. stop creating new streams on it). Results: The client can manage keepalive and connection idling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Clients can be configured to use keepalive which periodically sends PING frames to the server, typically only if streams are open, but this behaviour is configurable. Clients should also close connections after periods of inactivity (if no streams are open).
Modifications:
Add a client channel handler and state machine which handles client side keepalive and connection idling.
The handler also emits connection events to the next handler, these events can be used to determine whether to take the connection out of service (i.e. stop creating new streams on it).
Results:
The client can manage keepalive and connection idling.